Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-make-support: Add llvm-pdbutil #130048

Merged
merged 1 commit into from
Sep 9, 2024
Merged

run-make-support: Add llvm-pdbutil #130048

merged 1 commit into from
Sep 9, 2024

Conversation

nebulark
Copy link
Contributor

@nebulark nebulark commented Sep 6, 2024

Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.

r? @jieyouxu
@rustbot label: +O-windows

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2024

The run-make-support library was changed

cc @jieyouxu

@rustbot rustbot added the O-windows Operating system: Windows label Sep 6, 2024
@nebulark
Copy link
Contributor Author

nebulark commented Sep 6, 2024

I'd like to add this so I can implement unit tests like this:
#130049

kadiwa4
kadiwa4 reviewed Sep 6, 2024
View reviewed changes
src/tools/run-make-support/src/external_deps/llvm.rs Outdated
@@ -110,6 +110,13 @@ pub struct LlvmDwarfdump {
cmd: Command,
}

/// A `llvm-dwarfdump` invocation builder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*llvm-pdbutil

@Kobzol
Copy link
Contributor

Kobzol commented Sep 7, 2024 •
edited
Loading

FWIW, in general, I think that you can just add utilites such as these with the first PR/test that requires them. This code isn't large, so it does not need to be landed separately, but sometimes it happens that we land the infrastructure, but not the followup tests (for whatever reason), and then it's unused :)

jieyouxu
jieyouxu approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems fine since you do already have a draft PR that will use this bin-util. Could you squash the commits into one? Then r=me.

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2024
@nebulark nebulark force-pushed the runmake_llvm_pdbutil branch from 94311be to ec11001 Compare September 8, 2024 12:18
@nebulark
Copy link
Contributor Author

nebulark commented Sep 8, 2024

Squashed commits.
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Sep 8, 2024

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 8, 2024

📌 Commit ec11001 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#130048 - nebulark:runmake_llvm_pdbutil, r=j…
16dadb8 
…ieyouxu

run-make-support: Add llvm-pdbutil

Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.

r? `@jieyouxu`
`@rustbot` label: +O-windows
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2024
@bors
Auto merge of rust-lang#130109 - matthiaskrgr:rollup-tnuoj7e, r=matth…
8f429c5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129473 (use  `download-ci-llvm=true` in the default compiler config)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations)
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#130048 - nebulark:runmake_llvm_pdbutil, r=j…
8678d8d 
…ieyouxu

run-make-support: Add llvm-pdbutil

Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.

r? ``@jieyouxu``
``@rustbot`` label: +O-windows
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#130048 - nebulark:runmake_llvm_pdbutil, r=j…
3a0ee3f 
…ieyouxu

run-make-support: Add llvm-pdbutil

Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.

r? ```@jieyouxu```
```@rustbot``` label: +O-windows
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130129 - workingjubilee:rollup-yfakrkp, r=wor…
23ed20d 
…kingjubilee

Rollup of 16 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130133 - workingjubilee:rollup-t5o827k, r=wor…
1f44f0a 
…kingjubilee

Rollup of 14 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)
 - rust-lang#130130 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 97d62ac into rust-lang:master Sep 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@rust-timer
Unrolled build for rust-lang#130048
35664cc 
Rollup merge of rust-lang#130048 - nebulark:runmake_llvm_pdbutil, r=jieyouxu

run-make-support: Add llvm-pdbutil

Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.

r? ````@jieyouxu````
````@rustbot```` label: +O-windows
@nebulark nebulark mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadiwa4 kadiwa4 kadiwa4 left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nebulark @rustbot @Kobzol @jieyouxu @bors @kadiwa4